oshelper: wait for hidden window before taking screenshot on macOS - #4663
Open
selsta wants to merge 1 commit into
Open
oshelper: wait for hidden window before taking screenshot on macOS#4663selsta wants to merge 1 commit into
selsta wants to merge 1 commit into
Conversation
Also improve error message and add a missing include.
selsta
force-pushed
the
macos-screen-capture
branch
from
July 19, 2026 18:43
fcddecc to
62d0a59
Compare
jpk68
reviewed
Aug 3, 2026
| catch (const std::exception &e) | ||
| { | ||
| qWarning() << e.what(); | ||
| qWarning() << "QR screen capture: decoder exception:" << e.what(); |
Contributor
There was a problem hiding this comment.
Nit: spacing before error text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for macOS. In the future I'll switch to ScreenCaptureKit but that will require larger changes.